Comments on: RELEASE: Redirect Routing Plugin for Rails

By: Pelle

Pelle — Tue, 18 Jul 2006 22:03:00 +0000

Very useful. I will definitely use it.

By: Jarkko Laine

Jarkko Laine — Tue, 18 Jul 2006 22:03:00 +0000

Very cool, Lars. That sounds extremely useful for supporting legacy url’s. Any plans to make it support variables/regexps?

Like:



map.redirect ‘blog/:id’,

   Proc.new{|id|

        @post = Post.find(id)

        {:day => @post.day, … , :title => @post.title}

  }

Ok, maybe that was a bit too involved… but it *would* make supporting textpattern-type url’s easy in Typo

By: Lars Pind

Lars Pind — Tue, 18 Jul 2006 22:03:00 +0000

Interesting idea.

I’m thinking the routes should stay declarative. They’re not meant as a replacement for controllers.

I could see how you’d want to do some simple regsubbing or use of parameters, but I think it ends there.

By: Thijs van der Vossen

Thijs van der Vossen — Tue, 18 Jul 2006 22:03:00 +0000

Very nice! Would be great to have this in Rails by default. Why not try to get it in there for the next release?

By: Lars Pind

Lars Pind — Tue, 18 Jul 2006 22:03:00 +0000

The only problem is that I’m creating a special controller behind the scenes and then leveraging the normal controller and response’s url rewriting and redirecting capabilities.

The rewriting part is actually handled by the Routing system, so that should be easy, and sending the redirect is trivial, so that could be done as well, but it wouldn’t be completely DRY.

If there’s interest from core I’ll be happy to explore.

By: robin

robin — Tue, 18 Jul 2006 22:03:00 +0000

when i put this in my vendors/plugins I get the following…

… /dependencies.rb:123:in `const_missing’: uninitialized constant Mapper (NameError)
from /usr/local/lib/ruby/gems/1.8/gems/activesupport-1.3.1/lib/active_support/dependencies.rb:133:in `const_missing’

rails don’t start..

something I’m missing?

By: Lars Pind

Lars Pind — Tue, 18 Jul 2006 22:03:00 +0000

Did I mention this only works with edge and the rewritten routing implementation?

By: Daniel Butler

Daniel Butler — Tue, 18 Jul 2006 22:03:00 +0000

I get the same error as robin while I’m trying to set this up on a customized Typo installation, which is pegged to non-edge Rails. Anyone have any suggestions about how to accomplish redirects (or support for legacy URLs) without this plugin?

By: Craig Barber

Craig Barber — Tue, 18 Jul 2006 22:03:00 +0000

I altered your plugin to support:

map.redirect ‘/old_controller/:action’,
:controller => ‘new_controller’

by adding the following to RedirectRoutingController:

def method_missing(action)
redirect_to params[:url_options].merge({ :action => action })
end

P.S. – I *really* like the automatic code detection. Is that part of typo?

By: Lee Iverson

Lee Iverson — Tue, 18 Jul 2006 22:03:00 +0000

OK, so I bit the (very soft) bullet and got this working with regexps in the redirect options. The changes are simple:



module RedirectRouting

  module Routes

    def redirect(path, options={})

      url_options = { }

      connect_options = {

        :controller => "redirect_routing", :action => "redirect",

        :url_options => url_options }

      options.each do |key,value|

        if [:controller, :action].include?(key)

          url_options[key] = value

        else

          connect_options[key] = value

        end

      end

      connect path, connect_options

    end

  end

end

and



class RedirectRoutingController < ActionController::Base

  def redirect

    url_options = params.delete(:url_options)

    redirect_to params.merge(url_options)

  end

end